Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I can't move the main window #9964

Closed
1 task done
fredix opened this issue Mar 29, 2024 · 1 comment · Fixed by #11525
Closed
1 task done

I can't move the main window #9964

fredix opened this issue Mar 29, 2024 · 1 comment · Fixed by #11525
Labels
defect [core label] linux mouse interaction Feedback for mouse interaction states, actions, etc workspace Feedback for workspace management, layout, interactions, etc

Comments

@fredix
Copy link

fredix commented Mar 29, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When I try to move Zed with the mouse pointer on the top bar, it's impossible to move. Anyway I can move it with a push on the window key and click the left mouse button.

Environment

I'm using on both distribution, Wayland.

Zed: v1.0.0 (Zed)
OS: Linux 1.0.0
Memory: 30.6 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log
@fredix fredix added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Mar 29, 2024
@JosephTLyons JosephTLyons added workspace Feedback for workspace management, layout, interactions, etc linux and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Mar 29, 2024
@jansol
Copy link
Contributor

jansol commented Mar 29, 2024

Client-side decorations for Wayland have not been implemented yet and this would be part of those.

This was referenced Mar 30, 2024
Open
Open
@Moshyfawn Moshyfawn mentioned this issue May 8, 2024
Closed
1 task
@Moshyfawn Moshyfawn added the mouse interaction Feedback for mouse interaction states, actions, etc label May 8, 2024
@apricotbucket28 apricotbucket28 mentioned this issue May 8, 2024
Merged
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
@apricotbucket28 @aki237 @osiewicz
wayland: Window controls and drag (zed-industries#11525)
fb2b42b 
Based on zed-industries#11046

- Partially fixes zed-industries#10346 
- Fixes zed-industries#9964

## Features
Window buttons

![image](https://github.com/zed-industries/zed/assets/71973804/1b7e0504-3925-45ba-90b5-5adb55e0d739)

Window drag

![image](https://github.com/zed-industries/zed/assets/71973804/9c509a37-e5a5-484c-9f80-c722aeee4380)

Native window context menu

![image](https://github.com/zed-industries/zed/assets/71973804/048ecf52-e277-49bb-a106-91cad226fd8a)

### Limitations

- No resizing
- Wayland only (though X11 always has window decorations)

### Technical

This PR adds three APIs to gpui.

1. `show_window_menu`: Triggers the native title bar context menu.
2. `start_system_move`: Tells the compositor to start dragging the
window.
3. `should_render_window_controls`: Whether the compositor doesn't
support server side decorations.

These APIs have only been implemented for Wayland, but they should be
portable to other platforms.

Release Notes:

- N/A

---------

Co-authored-by: Akilan Elango <akilan1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] linux mouse interaction Feedback for mouse interaction states, actions, etc workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wayland: Window controls and drag apricotbucket28/zed
4 participants
@fredix @jansol @Moshyfawn @JosephTLyons