Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Linux platform implementation #10227

Merged
merged 11 commits into from
Apr 8, 2024
Merged

Refactor Linux platform implementation #10227

merged 11 commits into from
Apr 8, 2024

Conversation

mikayla-maki
Copy link
Contributor

@mikayla-maki mikayla-maki commented Apr 6, 2024

This puts the Linux platform implementation at a similar code style and quality to the macOS platform. The largest change is that I collapsed the LinuxPlatform -> [Backend] -> [Backend]State -> [Backend]StateInner to just [Backend] and [Backend]State, and in the process removed most of the Rcs and RefCells.

TODO:

  • Make sure that this is on-par with the existing implementation
  • Review in detail, now that the large changes are done.
  • Update the roadmap

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 6, 2024
@mikayla-maki mikayla-maki self-assigned this Apr 8, 2024
@mikayla-maki mikayla-maki merged commit def87a8 into main Apr 8, 2024
10 checks passed
@mikayla-maki mikayla-maki deleted the linux-shred branch April 8, 2024 23:40
@mikayla-maki mikayla-maki changed the title WIP: Refactor Linux platform implementation Refactor Linux platform implementation Apr 9, 2024
mikayla-maki pushed a commit that referenced this pull request Apr 10, 2024
Release Notes:

- Partially (Wayland implementation) Fixed
[#10124](#10124)).

The recent refactor of the linux gpui implementation
(#10227) broke the wayland
cursor update logic by setting the cursor icon as `None`. Fix it by
setting the `cursor_icon_name`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant