-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Linux platform implementation #10227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkpoint: Commented out wayland, converted general linux platform and x11 client
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
Apr 6, 2024
mikayla-maki
force-pushed
the
linux-shred
branch
from
April 6, 2024 06:06
2292d35
to
6449b43
Compare
mikayla-maki
force-pushed
the
linux-shred
branch
from
April 6, 2024 06:14
6449b43
to
fa509dc
Compare
mikayla-maki
changed the title
WIP: Refactor Linux platform implementation
Refactor Linux platform implementation
Apr 9, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts the Linux platform implementation at a similar code style and quality to the macOS platform. The largest change is that I collapsed the
LinuxPlatform
->[Backend]
->[Backend]State
->[Backend]StateInner
to just[Backend]
and[Backend]State
, and in the process removed most of theRc
s andRefCell
s.TODO:
Release Notes: