Attachment store for assistant2 #11327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
rgbkrk
force-pushed
the
asst2-push-contexts
branch
2 times, most recently
from
36a81ba
to
b6352d4
Compare
rgbkrk
force-pushed
the
asst2-push-contexts
branch
from
6e17ffb
to
c0563f4
Compare
Co-Authored-By: Marshall <marshall@zed.dev>
Co-Authored-By: Marshall <marshall@zed.dev>
Co-Authored-By: Marshall <marshall@zed.dev>
rgbkrk
force-pushed
the
asst2-push-contexts
branch
from
c92ff0e
to
2003597
Compare
maxbrunsfeld
added a commit
that referenced
this pull request
May 4, 2024
Chat message rendering was restructured in #11327, but it caused tool calls not to be rendered if the assistant hadn't generated any message text. before:  after: <img width="518" alt="Screenshot 2024-05-03 at 11 17 45 PM" src="https://github.com/zed-industries/zed/assets/326587/34de19ba-daf2-4ac1-9fe0-f51d0ce94872"> Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up a way for the user (or Zed) to push context instead of having the model retrieve it with a function. Our first use is the contents of the current file.
I heard the asst2 example was deleted in another branch so I deleted that here too since we wanted the workspace access.
Release Notes: