Always default to creating a new window on open recent

[effdotsh]

Release Notes:

• Fixed Open project behaves inconsistently #12202

There are three methods of prompting to open a recent project. Using the keyboard shortcut, using the menu bar, and clicking the project name in the top left of the window. Before, clicking the project name would map enter to reusing the current window and while ⌘enter opens the project in a new window, and the other two had the reverse mapping. This PR standardizes all three methods to open a new window by default, and reuse the same window with the command key.

[effdotsh]

Converting to a draft so I can examine the test later

[effdotsh]

Ok it's all good

[RemcoSmitsDev]

I think this change is going to confuse a lot of people, because it behaves different to how most modern applications work. For example, if you look how the browser behaves. If you click a link, it would open it inside the current tab unless someone specified that it should open in a new blank tab. Or, if you want to open it in a new tab your self, you hold the command key while clicking the link.

So changing this would not make sense to me. Feel like this would be a breaking change for a lot of people. It would make more sense if you add a setting to determine this, so the people that would love to opt out the normal behavior can do this just by changing the setting.

[VladasZ]

There is such settings. You need to attach it to key binding.
See Default Key Bindings:

  {
    "context": "Workspace",
    "bindings": {
      // Change the default action on `menu::Confirm` by setting the parameter
      // "alt-cmd-o": [
      //     "projects::OpenRecent",
      //     {
      //         "create_new_window": true
      //     }
      // ]
      "alt-cmd-o": "projects::OpenRecent",

I'm a new zed user and this situation was a bit confusing for me too. At first I tried to find this setting in settings.json but actually it needs to be set in keymap.json.

[RemcoSmitsDev]

I think this PR can be closed in favor of #12525.

[effdotsh]

Personally, I feel it makes more sense to open in separate windows rather than the current one as a default (easier to close an open window than reopen a project you accidentally closed), but happy to be overruled on that and #12525 makes it configurable.