Adjust IME action buffering to only apply to insert actions #12702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for more IME edge cases co-authored-by: Conrad <conrad@zed.dev>
cla-bot
bot
added
the
cla-signed
jansol
approved these changes
Jun 5, 2024
This was referenced Jun 6, 2024
|
Ooopppps, @mikayla-maki After my testing Screen.Recording.2024-06-13.at.07.17.16.mov |
|
@mikayla-maki After this commit, the value of ime in KeyDownEvent within gpui's on_key_down has always been None. Does this meet your expectations? If so, what should I do to revert it back to being able to obtain ime as before? |
|
@suxiaoshao That was a bug, it has been fixed! |
mikayla-maki
added a commit
that referenced
this pull request
Jun 20, 2024
This fixes a bug introduced by #12702, where GPUI would only generate the correct key events if you had an input handler set. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #12678
fixes #11829
In this solution, we only buffer Insert Text actions from the macOS IME. The marked text and unmark actions are eagerly processed, so that the IME state is synchronized with the editor state during multi step pre-edit composition.
Release Notes: