Prevent folder expansion when all items are closed #12729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @panghu-huang on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
osiewicz
reviewed
Jun 6, 2024
ming900518
pushed a commit
to ming900518/zed
that referenced
this pull request
Jun 14, 2024
) Release Notes: - Prevent folder expansion when all items are closed ### Problem When all items are closed, the next activated file expands (see the video below). https://github.com/zed-industries/zed/assets/21101490/a7631cd2-4e97-4954-8b01-d283dd4796be ### Cause When the currently active item is closed, Zed tries to activate the previously active item. Activating an item by default expands the corresponding folder, which can result in folders being expanded when all files are closed. ### Fixed Video https://github.com/zed-industries/zed/assets/21101490/d30f05c5-6d86-4e11-b349-337fa75586f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Problem
When all items are closed, the next activated file expands (see the video below).
2024-06-06.20.42.48.mov
Cause
When the currently active item is closed, Zed tries to activate the previously active item. Activating an item by default expands the corresponding folder, which can result in folders being expanded when all files are closed.
Fixed Video
2024-06-06.20.46.02.mov