vim: Implement named registers

[p-A-uLo]

Release Notes:

• vim: Add support for register selection "a-"z, "0-"9, "-. "_ and "% (#11511)

[ConradIrwin]

🥳 Awesome!

@p-A-uLo I think it would be best to do this in the way we do marks where we just wait for input after the " instead of hardcoding the ascii range. Was there a reason you chose to do it this way?

Happy to talk this through if you want: https://calendly.com/conradirwin/pairing

[p-A-uLo]

@ConradIrwin Ok, I'll look into it.

[p-A-uLo]

@ConradIrwin I implemented the changes you proposed. I may have done something wrong though : to avoid conflicts I rebased and force pushed. Now CI fails. Could you have a look ?

[ConradIrwin]

re-running....

[ConradIrwin]

@p-A-uLo I read though this more, and looked at the vim docs, and came to a few conclusions:

• I think we should identify registers by char and store them in a hash map so we can support the various special vim registers as well as any characters people want to use, and we don't need to pre-allocate a mostly empty array.
• "0 (used for yanks) is actually different from "1-"9 (used for multi-line deletes) and they are both different again from "- (who knew!)
• "+ and "* always talk directly to the system clipboard
• I think we can ship this without supporting all the special registers. For now I've added "%. I think "/, "#, ":, ". would be pretty easy to add, but "= is probably a won't fix for now.

I ended up refactoring as part of exploring how should work, so I've updated this branch with that.

Anything else you think we should do? Otherwise I think this is good to merge.

[0x2CA]

hi ,vim Command display #4447 The function is broken.

[ConradIrwin]

Thanks @0x2CA - added that!

[baldwindavid]

Amazing work, @p-A-uLo and @ConradIrwin ! This is a really big deal.

[p-A-uLo]

Thanks @ConradIrwin, this is making zed a quite good vim now !

[ConradIrwin]

thank you too! Keep the PRs coming :D.