Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cross-platform file-watching #6855

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Jan 27, 2024

This adds cross-platform file-watching via the Notify crate. The previous fs-events implementation is now only used on MacOS, and on other platforms Notify is used. The watching function interface is the same.

Related to #5391 #5395 #5394.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 27, 2024
@aminya aminya changed the title feat: introduce cross-platform file-watching @aminya feat: introduce cross-platform file-watching Jan 27, 2024
@aminya aminya force-pushed the cross-platform-fs-watch branch 4 times, most recently from 4d80e7f to cc3ec84 Compare January 27, 2024 12:39
@williamdes williamdes mentioned this pull request Jan 27, 2024
crates/fs/src/fs.rs Outdated Show resolved Hide resolved
@maxdeviant maxdeviant changed the title feat: introduce cross-platform file-watching Introduce cross-platform file-watching Jan 27, 2024
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move on with this one.
One small nit I have is that both events are called Event, but we'll see how confusing it gets in the future.

@SomeoneToIgnore SomeoneToIgnore merged commit 1313402 into zed-industries:main Jan 29, 2024
4 checks passed
@aminya aminya mentioned this pull request Jan 30, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants