Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent terminal being a single column wide #7471

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Prevent terminal being a single column wide #7471

merged 1 commit into from
Feb 7, 2024

Conversation

ConradIrwin
Copy link
Collaborator

@ConradIrwin ConradIrwin commented Feb 7, 2024 •
edited by maxdeviant

Fixes: #2750
Fixes: #7457

Release Notes:

  • Fixed a hang/panic that could happen rendering a double-width character in a single-width terminal (#2750, #7457).

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 7, 2024
This was referenced Feb 7, 2024
Closed
Open
@ConradIrwin ConradIrwin merged commit 90cd3b5 into main Feb 7, 2024
7 checks passed
@ConradIrwin ConradIrwin deleted the fix-killer-crabs branch February 7, 2024 03:25
@mrnugget
Copy link
Member

mrnugget commented Feb 7, 2024

Wow, nice find!

ConradIrwin added a commit that referenced this pull request Feb 7, 2024
@ConradIrwin
Prevent terminal being a single column wide (#7471)
d10588d 
Fixes: #2750
Fixes: #7457



Release Notes:

- Fixed a hang/panic that could happen rendering a double-width
character in a single-width terminal
([#2750](#2750),
[#7457](#7457)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shortening window pane causes app crash and prompts macos to force kill Killer crabs promptly induce panic
2 participants
@ConradIrwin @mrnugget