Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of traffic lights #8128

Merged
merged 4 commits into from
Feb 24, 2024
Merged

Fix alignment of traffic lights #8128

merged 4 commits into from
Feb 24, 2024

Conversation

slymax
Copy link
Contributor

@slymax slymax commented Feb 21, 2024

closes #7339

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 21, 2024
@maxdeviant maxdeviant self-assigned this Feb 21, 2024
@maxdeviant
Copy link
Member

These don't seem aligned to me:

Screenshot 2024-02-21 at 11 46 33 AM

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the traffic lights being misaligned with other elements in the title bar.

@slymax
Copy link
Contributor Author

slymax commented Feb 21, 2024

idk looks fine on my end:

Bildschirmfoto 2024-02-21 um 19 22 20

maybe this has to do with the ui_font_size setting

the traffic lights are in the middle of the title bar – also on your screenshot

on your screenshot it looks like the other elements are a bit too far up

@slymax
Copy link
Contributor Author

slymax commented Feb 23, 2024

nvm I moved them up a bit so they look more aligned with the default ui_font_size setting

Bildschirmfoto 2024-02-23 um 19 49 23

@probablykasper
Copy link

The traffic light position should just be in the middle of the title bar, don't consider the text. Though you gotta think of the window border included as part of the title bar. Illustration:
image

If the text looks misaligned, the text itself would need to be moved (and in that case, consider the alignment of uppercase characters and other alphabets)

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now!

@maxdeviant maxdeviant merged commit 622cae1 into zed-industries:main Feb 24, 2024
7 checks passed
osiewicz added a commit that referenced this pull request Mar 26, 2024
It looks like a fractional traffic lights position doesn't play well with Mac 12+.
Related to #7339 and #8128
osiewicz added a commit that referenced this pull request Mar 26, 2024
It looks like a fractional traffic lights position doesn't play well with Mac 12+.
Related to #7339 and #8128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window Decoration Buttons Misalignment
3 participants