Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows paths fix #2

Closed
wants to merge 3 commits into from
Closed

Windows paths fix #2

wants to merge 3 commits into from

Conversation

chukonu
Copy link

@chukonu chukonu commented Mar 20, 2015

This branch tries to fix the issue with file paths on Windows, as Windows uses backslashes instead of forward slashes.

A proxy library, upath, is included to replace the original reference to the built-in module path.

In loader.js, path#basename is used instead of String#replace to retrieve the last portion, excluding the file type suffix, of a path.

@coveralls
Copy link

Coverage Status

Coverage decreased (-23.31%) to 76.69% when pulling c312cdc on tiaoshi:windows-fix into 46a78b8 on zedgu:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-23.31%) to 76.69% when pulling c312cdc on tiaoshi:windows-fix into 46a78b8 on zedgu:master.

@zedgu
Copy link
Owner

zedgu commented Mar 20, 2015

Thank you for your work.
But it failed the test for now, I'll marge the PR when CI build passed.

@chukonu
Copy link
Author

chukonu commented Mar 22, 2015

Thanks for your reply, Zed. I'll try again.

@chukonu chukonu closed this Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants