-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the homepage #31
Conversation
Thank you @syndbg for this ! 👍 Don't worry about Wercker, it's not a blocking point, I have to fix it but Shippable is the one I'm looking to. |
|
@syndbg the pagination works great, but the counters of the tabs are then wrong. |
bc99e8e
to
88f0110
Compare
@zedtux I made the counters weird. They would increment on pagination which at that time when I was writing the PR... it might've made sense. Anyway, now the counters display the total count of all / new / inactive formulas as they should. |
Counters are now fine but the pagination is no more working :s |
I can see a call to 'http://localhost:3000/?format=json&page=2' but the page doesn't refresh. |
@zedtux Page should not refresh. It's "SPA"-like. It updates the displayed items, but does not refresh the page. Refreshing the page on each page completely kills the user experience. |
Sorry, I wasn't clear enough. It's not it should refresh the page, it should update the page. The first test I did, the page was updating on scrolling, but now it's no more the case. |
@syndbg do you have some news ? I'm waiting on this PR in order to build a new release for prod :) |
I was quite busy at that week (and more). I will look at the PR again after work. (EET here) |
Than you :) No worries I was just pinging you ;) |
88f0110
to
4ac16b4
Compare
@zedtux Fixed. Sorry for the delays. |
It working fine ! 👍 |
Addresses #17