Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the homepage #31

Merged
merged 2 commits into from
Nov 8, 2015
Merged

Conversation

syndbg
Copy link
Contributor

@syndbg syndbg commented Oct 2, 2015

Addresses #17

@zedtux
Copy link
Owner

zedtux commented Oct 5, 2015

Thank you @syndbg for this ! 👍

Don't worry about Wercker, it's not a blocking point, I have to fix it but Shippable is the one I'm looking to.
I have to give it a try but the code is fine to me.
Feel free to ping me in case you don't see an update during the week.

@syndbg
Copy link
Contributor Author

syndbg commented Oct 12, 2015

Feel free to ping me in case you don't see an update during the week.
@zedtux ping.

@zedtux
Copy link
Owner

zedtux commented Oct 21, 2015

@syndbg the pagination works great, but the counters of the tabs are then wrong.

@syndbg
Copy link
Contributor Author

syndbg commented Oct 21, 2015

@zedtux I made the counters weird. They would increment on pagination which at that time when I was writing the PR... it might've made sense.

Anyway, now the counters display the total count of all / new / inactive formulas as they should.

@zedtux
Copy link
Owner

zedtux commented Oct 24, 2015

Counters are now fine but the pagination is no more working :s

@zedtux
Copy link
Owner

zedtux commented Oct 24, 2015

I can see a call to 'http://localhost:3000/?format=json&page=2' but the page doesn't refresh.

@syndbg
Copy link
Contributor Author

syndbg commented Oct 26, 2015

@zedtux Page should not refresh. It's "SPA"-like. It updates the displayed items, but does not refresh the page.

Refreshing the page on each page completely kills the user experience.

@zedtux
Copy link
Owner

zedtux commented Oct 26, 2015

Sorry, I wasn't clear enough. It's not it should refresh the page, it should update the page. The first test I did, the page was updating on scrolling, but now it's no more the case.

@zedtux
Copy link
Owner

zedtux commented Nov 3, 2015

@syndbg do you have some news ? I'm waiting on this PR in order to build a new release for prod :)

@syndbg
Copy link
Contributor Author

syndbg commented Nov 3, 2015

I was quite busy at that week (and more). I will look at the PR again after work. (EET here)

@zedtux
Copy link
Owner

zedtux commented Nov 3, 2015

Than you :) No worries I was just pinging you ;)

@syndbg
Copy link
Contributor Author

syndbg commented Nov 3, 2015

@zedtux Fixed. Sorry for the delays.

@zedtux
Copy link
Owner

zedtux commented Nov 8, 2015

It working fine ! 👍

zedtux added a commit that referenced this pull request Nov 8, 2015
@zedtux zedtux merged commit ee668b2 into zedtux:master Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants