Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 charset fix :P #17

Merged
merged 1 commit into from Jun 13, 2017
Merged

UTF-8 charset fix :P #17

merged 1 commit into from Jun 13, 2017

Conversation

Behoston
Copy link

@Behoston Behoston commented Apr 29, 2017

resolve #16
and probably #10

Copy link
Owner

@zedwick zedwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll test that later.

Could you revert the version change in your PR though, please.

README Outdated
@@ -1,7 +1,7 @@
##########################################
## ##
## Bungee Chat Filter Config ##
## v1.7 ##
## v1.8 ##
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please not change the version number in your PR, thanks.

pom.xml Outdated
@@ -6,7 +6,7 @@

<groupId>BungeeChatFilter</groupId>
<artifactId>BungeeChatFilter</artifactId>
<version>1.7</version>
<version>1.8</version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change version in PR, please

@@ -1,7 +1,7 @@
##########################################
## ##
## Bungee Chat Filter Config ##
## v1.7 ##
## v1.8 ##
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change version in PR, please

@Behoston
Copy link
Author

Reverted

@zedwick zedwick merged commit d421fa1 into zedwick:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UFT-8 Support
2 participants