Re-enable tab entry and ensure the cursor is moved the correct width #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `insert-tab` binding was a no-op because DISABLE_TABS is `false` causing insert_tab() not to be run. Remove the guard around insert_tab() to ensure that a tab (or spaces) are outputted and correct the calculation of the distance to move horizontally to work in both the tab and pseudo-tab (spaces) cases. Tested with DISABLE_TABS set to `true` (i.e. insert spaces) and `false`.
mcobzarenco
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
insert-tabbinding was a no-op because DISABLE_TABSis
falsecausing insert_tab() not to be run. Remove the guard aroundinsert_tab() to ensure that a tab (or spaces) are outputted and
correct the calculation of the distance to move horizontally to work in
both the tab and pseudo-tab (spaces) cases.
Tested with DISABLE_TABS set to
true(i.e. insert spaces) andfalse.