[Enhancement] Maintain config.ron, Add Haskell
#62
Conversation
There was a problem hiding this comment.
Thank you for this, super useful! Adding Haskell was on my todo list too! 🙇
Not a big fan of comment boxes, see below. I had one other meta-comment re: splitting changes into multiple commits / PRs. E.g. would be easy to just merge Haskell addition and discuss style changes in a separate PR -- obviously there's a balance, but stylistic things are prone to bike shedding :-)
There was a problem hiding this comment.
Looks good to me, thanks! Please squash the 2nd commit and I'll merge it.
EDIT: @kevinmatthes Could you also add a line in the changelog please referencing the newly added support for Haskell 🎉
kevinmatthes
force-pushed
the
feature/modes-haskell
branch
from
d3feddc
to
a5a1666
Compare
This Pull Request fixes typos in the comments, adds comment banners and introduces a Tree-Sitter for Haskell.
kevinmatthes
force-pushed
the
feature/modes-haskell
branch
from
d9388e1
to
359ba33
Compare
|
Squashing will cause problems with the base branch which need to be resolved. The newly added changelog line will not be accepted and the configuration will be damaged. Squashing these three commits into one is not possible, at least not for me. You can also choose to merge by squash in order to solve the problem of multiple commits. |
kevinmatthes
force-pushed
the
feature/modes-haskell
branch
from
fce7bc9
to
ae59e0f
Compare
|
On the git point,
You should checkout latest master and git rebase interactive this branch on it, i.e |
|
I've created a squashed version #75 -- I may merge that one (you still appear as the author in the commit)
I honestly don't see any reason to wait for as that's a major change as there's immediate value in merging this PR -- better documentation and support for Haskell 🎉 |
|
Merged in #75 |
This Pull Request fixes typos in the comments, adds comment banners and introduces a Tree-Sitter for Haskell.