feat(clients/java): propagate job worker exception message to broker

camunda · Dec 11, 2018 · 23a70ea · 23a70ea
1 parent 4f99d24
commit 23a70ea
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/clients/java/src/main/java/io/zeebe/client/impl/subscription/JobRunnableFactory.java b/clients/java/src/main/java/io/zeebe/client/impl/subscription/JobRunnableFactory.java
@@ -47,7 +47,11 @@ private void executeJob(ActivatedJob job, Runnable doneCallback) {
           job.getKey(),
           job.getType(),
           e);
-      jobClient.newFailCommand(job.getKey()).retries(job.getRetries() - 1).send();
+      jobClient
+          .newFailCommand(job.getKey())
+          .retries(job.getRetries() - 1)
+          .errorMessage(e.getMessage())
+          .send();
     } finally {
       doneCallback.run();
     }

diff --git a/qa/integration-tests/src/test/java/io/zeebe/broker/it/job/JobWorkerTest.java b/qa/integration-tests/src/test/java/io/zeebe/broker/it/job/JobWorkerTest.java
@@ -261,11 +261,12 @@ public void shouldFailJobWithErrorMessage() {
   public void shouldMarkJobAsFailedAndRetryIfHandlerThrowsException() {
     // given
     final long jobKey = createJobOfType("foo");
+    final String failureMessage = "expected failure";
 
     final RecordingJobHandler jobHandler =
         new RecordingJobHandler(
             (c, j) -> {
-              throw new RuntimeException("expected failure");
+              throw new RuntimeException(failureMessage);
             },
             (c, j) -> c.newCompleteCommand(j.getKey()).send().join());
 
@@ -284,7 +285,10 @@ public void shouldMarkJobAsFailedAndRetryIfHandlerThrowsException() {
     assertThat(jobHandler.getHandledJobs())
         .extracting(ActivatedJob::getKey)
         .containsExactly(jobKey, jobKey);
-    assertThat(jobRecords(JobIntent.FAILED).exists()).isTrue();
+
+    final Record<JobRecordValue> failedJob = jobRecords(JobIntent.FAILED).getFirst();
+    assertThat(failedJob.getValue()).hasErrorMessage(failureMessage);
+
     waitUntil(() -> jobRecords(JobIntent.COMPLETED).exists());
   }