Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(surefire): rerun flaky tests up to 3 times before failing the build #1139

Merged
merged 1 commit into from Aug 3, 2018

Conversation

menski
Copy link
Contributor

@menski menski commented Aug 2, 2018

The test suite has some flaky tests which reduces the value of the CI as the developer has to analyse the build log and decide whether a failed test is a real problem or flaky test. To reduce this we will now rerun failing tests up to 3 times before failing the build.

closes #1138

The test suite has some flaky tests which reduces the value of the CI as the
developer has to analyse the build log and decide whether a failed test is a
real problem or flaky test. To reduce this we will now rerun failing tests
up to 3 times before failing the build.
@menski menski requested a review from jsam August 2, 2018 18:14
@ghost ghost assigned menski Aug 2, 2018
@ghost ghost added the needs review label Aug 2, 2018
@jsam
Copy link
Contributor

jsam commented Aug 3, 2018

bors r+

bors bot added a commit that referenced this pull request Aug 3, 2018
1139: ci(surefire):  rerun flaky tests up to 3 times before failing the build r=jsam a=menski

The test suite has some flaky tests which reduces the value of the CI as the developer has to analyse the build log and decide whether a failed test is a real problem or flaky test. To reduce this we will now rerun failing tests up to 3 times before failing the build.

closes #1138 


Co-authored-by: Sebastian Menski <sebastian@menski.org>
@bors
Copy link
Contributor

bors bot commented Aug 3, 2018

Build failed

@menski
Copy link
Contributor Author

menski commented Aug 3, 2018

bors retry

bors bot added a commit that referenced this pull request Aug 3, 2018
1139: ci(surefire):  rerun flaky tests up to 3 times before failing the build r=jsam a=menski

The test suite has some flaky tests which reduces the value of the CI as the developer has to analyse the build log and decide whether a failed test is a real problem or flaky test. To reduce this we will now rerun failing tests up to 3 times before failing the build.

closes #1138 


Co-authored-by: Sebastian Menski <sebastian@menski.org>
@bors
Copy link
Contributor

bors bot commented Aug 3, 2018

Build failed

@menski
Copy link
Contributor Author

menski commented Aug 3, 2018

bors r+

bors bot added a commit that referenced this pull request Aug 3, 2018
1139: ci(surefire):  rerun flaky tests up to 3 times before failing the build r=menski a=menski

The test suite has some flaky tests which reduces the value of the CI as the developer has to analyse the build log and decide whether a failed test is a real problem or flaky test. To reduce this we will now rerun failing tests up to 3 times before failing the build.

closes #1138 


Co-authored-by: Sebastian Menski <sebastian@menski.org>
@bors
Copy link
Contributor

bors bot commented Aug 3, 2018

Build succeeded

@bors bors bot merged commit 9dfd115 into develop Aug 3, 2018
@bors bors bot deleted the 1138-rerun-failing-tests branch August 3, 2018 11:02
@ghost ghost removed the needs review label Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic rerun of tests on CI
2 participants