Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(benchmark): Add best practices for windows systems #4209

Merged
merged 1 commit into from
Apr 22, 2020
Merged

chore(benchmark): Add best practices for windows systems #4209

merged 1 commit into from
Apr 22, 2020

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Apr 1, 2020

Description

  • Adds changes to Dockerfile to set execution permissions when building the Docker image
  • Adds best practices to documentation

Related issues

closes #4207

Pull Request Checklist

  • [ X ] All commit messages match our commit message guidelines
  • [ X ] The submitting code follows our code style
  • [ X ] If submitting code, please run mvn clean install -DskipTests locally before committing

@pihme pihme requested a review from Zelldon April 1, 2020 14:45
Zelldon
Zelldon reviewed Apr 8, 2020
View reviewed changes
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Peter sorry for the late response. Thanks for doing this. Please check my comments below.

benchmarks/setup/BestPracticesWindows.md Outdated Show resolved Hide resolved
benchmarks/setup/BestPracticesWindows.md Outdated Show resolved Hide resolved
benchmarks/setup/BestPracticesWindows.md Outdated Show resolved Hide resolved
benchmarks/setup/README.md Show resolved Hide resolved
@pihme pihme force-pushed the 4207-benchmarks-on-windows branch from ef9cc86 to d4a1418 Compare April 8, 2020 12:34
Zelldon
Zelldon approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing then I think we can merge it

benchmarks/README.md Outdated Show resolved Hide resolved
@Zelldon @pihme
chore(benchmark): Add best practices for windows systems
8dd5e5c 
Co-Authored-By: Christopher Zell <zelldon91@googlemail.com>
@pihme pihme force-pushed the 4207-benchmarks-on-windows branch from 2d2dbbc to 8dd5e5c Compare April 22, 2020 07:46
@pihme
Copy link
Contributor Author

pihme commented Apr 22, 2020

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Apr 22, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 3efde2a into develop Apr 22, 2020
@zeebe-bors zeebe-bors bot deleted the 4207-benchmarks-on-windows branch April 22, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zelldon Zelldon Zelldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmarks should also be runnable from Windows systems
4 participants
@pihme @Zelldon @npepinpe @lenaschoenburg