Introduce List storage for engine tests #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deepthidevaki part of this PR I refactored a bit the |
|
Can we remove entirely dependency on Atomix from the engine forever? Next is removing it from LogStream 😍 |
|
@npepinpe I tried but I needed the ZeebeEntry stuff but I think it is a step forward we can iterate/improve on that |
Zelldon
force-pushed
the
zell-list-storage
branch
from
25536f5
to
3856509
Compare
Looks good. Thanks 👍 |
|
@npepinpe nevermind was able to remove the atomix dep ✌️ |
|
@saig0 pingPong 🏓 |
|
bors r+ |
zeebe-bors bot
added a commit
that referenced
this pull request
Apr 14, 2020
4241: Introduce List storage for engine tests r=Zelldon a=Zelldon ## Description Replaces the AtomixLogStorage with an on heap ListStorage. Most of the tests are by factor 2 faster then before. For example variable.mappings tests before:  now:  The engine test suite now runs on jenkins with around 1:50 min, before 02:39 min. ## Related issues closes #4240 closes #4242 # Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Build failed |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the AtomixLogStorage with an on heap ListStorage.
Most of the tests are by factor 2 faster then before.
For example variable.mappings tests before:
now:
The engine test suite now runs on jenkins with around 1:50 min, before 02:39 min.
Related issues
closes #4240
closes #4242
Pull Request Checklist
mvn clean install -DskipTestslocally before committing