Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ActorThread before cast #4300

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Check ActorThread before cast #4300

merged 1 commit into from
Apr 14, 2020

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Apr 14, 2020

Description

Aavoids unnecessary class cast exceptions, see further information in issue description #4286

Related issues

closes #4286

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@Zelldon
chore(util/actor): check ActorThread before cast
d83523b 
 avoids unnecessary class cast exceptions
deepthidevaki
deepthidevaki approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepthidevaki
Copy link
Contributor

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Apr 14, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 836db1d into develop Apr 14, 2020
@zeebe-bors zeebe-bors bot deleted the 4286-actor-current branch April 14, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthidevaki deepthidevaki deepthidevaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Actor.current makes heavily use of class cast exceptions
4 participants
@Zelldon @deepthidevaki @npepinpe @lenaschoenburg