Replace array with list #4303
Merged
Replace array with list #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
reviewed
Apr 14, 2020
|
thansk @saig0 I just had to fix a concurrent modification exception, because some subscriptions remove them self on cancel 🤷♂️ :D |
Instead of using an array for the actor subscriptions and implementing the resizing by our self we using now a datastructure which is widely used for that: an ArrayList... On tryWait we want to verify the current subscriptions for that case we create a copy. We check the thread and make sure it is an actor thread on removing and adding a subscription.
Zelldon
force-pushed
the
4285-actor-subscriptions
branch
from
df8d4ad
to
5e9d932
Compare
|
bors r+ |
|
I checked with jmc again and saw no indication that to much allocations are happening outside of the TLAB, only ~2% was outside of the TLAB. Unfortunately I saw this thing not always, but I think we should have fixed this with the List. |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces inefficient usage of subscription array with an array list. Previous the subscription array was always copied and replaced by a smaller or larger array, when subscriptions where added or removed. With the usage of an array list the resizing is now a bit more efficient. For further information check #4285
Related issues
closes #4285
Pull Request Checklist
mvn clean install -DskipTestslocally before committing