Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(broker): apply the config of the debug HTTP exporter #4317

Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix(broker): apply the config of the debug HTTP exporter #4317

merged 1 commit into from
Apr 22, 2020

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Apr 16, 2020

Description

  • the port and the record limit of the debug HTTP exporter can be changed in the configuration

Related issues

closes #4316

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@saig0 saig0 requested a review from Zelldon April 16, 2020 12:53
Zelldon
Zelldon reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add getter/setter, otherwise we will automatically set it final again if someone opens the class. Furthermore we have no public field access.

@saig0
Copy link
Member Author

saig0 commented Apr 20, 2020

😅 ok, I'll add them

@saig0 saig0 requested a review from Zelldon April 20, 2020 04:52
Zelldon
Zelldon approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@saig0
fix(broker): apply the config of the debug HTTP exporter
5203da4 
* the port and the record limit of the debug HTTP exporter can be changed in the configuration
@saig0
Copy link
Member Author

saig0 commented Apr 22, 2020

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Apr 22, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit be161d4 into develop Apr 22, 2020
@zeebe-bors zeebe-bors bot deleted the 4316-debug-http-config branch April 22, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zelldon Zelldon Zelldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zeebe 0.22.1 debug-http exporter does not respect custom port
3 participants
@saig0 @Zelldon @npepinpe