Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(broker): fix flaky test #4369

Merged
merged 1 commit into from
Apr 24, 2020
Merged

test(broker): fix flaky test #4369

merged 1 commit into from
Apr 24, 2020

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Apr 24, 2020

Description

Make the test case more stable by not relying on the exact order of records.

Related issues

closes #4364

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@saig0 saig0 requested a review from pihme April 24, 2020 07:54
@pihme
Copy link
Contributor

pihme commented Apr 24, 2020

Should I trigger bors in simple cases like this, or do you want to rewrite commits and stuff?

@saig0
Copy link
Member Author

saig0 commented Apr 24, 2020

bors r+

zeebe-bors bot added a commit that referenced this pull request Apr 24, 2020
@zeebe-bors @saig0
Merge #4369
3ffe445 
4369: test(broker): fix flaky test r=saig0 a=saig0

## Description

Make the test case more stable by not relying on the exact order of records.

## Related issues

closes #4364 

#

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Apr 24, 2020

Build failed

@saig0
Copy link
Member Author

saig0 commented Apr 24, 2020

bors retry

@saig0
Copy link
Member Author

saig0 commented Apr 24, 2020

Failed because of another flaky test 🙈

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Apr 24, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit edc193c into develop Apr 24, 2020
@zeebe-bors zeebe-bors bot deleted the 4364-flaky-test branch April 24, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pihme pihme pihme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WorkflowInstanceStreamProcessorTest.shouldNotTriggerBoundaryEventIfTaskIsCompleted is flaky
4 participants
@saig0 @pihme @npepinpe @Zelldon