Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): don't update docker deps #4442

Merged
merged 1 commit into from May 4, 2020
Merged

Conversation

MiguelPires
Copy link
Contributor

Description

Since the Docker dependencies don't follow semver, they cause issues when the renovate bot tries to bump the version (e.g.., it "updates" to an old version). The presented error is not very obvious and usually requires a bit of googling to understand, so I'd prefer if this dependency was manually updated instead of having to deal with these PRs.
Hopefully, this PR makes the renovate bot ignore the Docker dependencies.

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@MiguelPires MiguelPires added the dependencies Pull requests that update a dependency file label May 4, 2020
@MiguelPires MiguelPires requested a review from npepinpe May 4, 2020 08:46
@MiguelPires MiguelPires self-assigned this May 4, 2020
@npepinpe
Copy link
Member

npepinpe commented May 4, 2020

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented May 4, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit d37fe49 into develop May 4, 2020
@zeebe-bors zeebe-bors bot deleted the ignore-docker-deps branch May 4, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants