chore(exporters/elasticsearch-exporter): remove high level rest client #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @korthout, I know we didn't talk about this before, but as menski is sick/has no time for this, I'd need someone else to review this :) Let's just quickly chat about it tomorrow before anything! |
korthout
requested changes
May 19, 2020
exporters/elasticsearch-exporter/src/main/java/io/zeebe/exporter/ElasticsearchClient.java
Show resolved
Hide resolved
exporters/elasticsearch-exporter/src/main/java/io/zeebe/exporter/ElasticsearchClient.java
Outdated
Show resolved
Hide resolved
exporters/elasticsearch-exporter/src/main/java/io/zeebe/exporter/ElasticsearchClient.java
Show resolved
Hide resolved
exporters/elasticsearch-exporter/src/main/java/io/zeebe/exporter/ElasticsearchClient.java
Outdated
Show resolved
Hide resolved
...ters/elasticsearch-exporter/src/test/java/io/zeebe/exporter/util/ElasticsearchContainer.java
Outdated
Show resolved
Hide resolved
|
Thanks for the quick review, I applied some of the feedback; I think only the new line one is still open. |
korthout
approved these changes
May 19, 2020
|
Updated to properly handle PutIndexTemplate requests, good catch! |
- replaces the high level rest client by the low level rest client - removes several elastic search dependencies
npepinpe
force-pushed
the
1343-elastic-low
branch
from
71040f1
to
6740ce3
Compare
korthout
approved these changes
May 19, 2020
|
bors r+ |
zeebe-bors bot
added a commit
that referenced
this pull request
May 19, 2020
4551: chore(exporters/elasticsearch-exporter): remove high level rest client r=npepinpe a=npepinpe ## Description This PR removes Elasticsearch's high level REST client and replaces it with the low level REST client, primarily to remove many heavy dependencies (such as embedding the Elasticsearch server itself) from the project. Out of scope was refactoring the exporter in general, though it could benefit from it. The scope here was strictly replacing the clients, which means most requests are simply maps, with a few DTOs to more easily handle responses. ## Related issues closes #1343 # Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
Build failed |
|
bors retry |
Build succeeded |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
) * feature(backend): add batch size throttling Related with #1590 * feature(backend): add set requestOptions for RecordsReader (for testing) Related with #1590 * feature(backend): add reset to NumberThrottleable Related with #1590 * feat(backend): clean up Related with #1590 * fix(backend): move setRequestOptions to ElasticsearchUtil Related with #1590 --------- Co-authored-by: Svetlana Dorokhova <svetlana.dorokhova@camunda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes Elasticsearch's high level REST client and replaces it with the low level REST client, primarily to remove many heavy dependencies (such as embedding the Elasticsearch server itself) from the project. Out of scope was refactoring the exporter in general, though it could benefit from it. The scope here was strictly replacing the clients, which means most requests are simply maps, with a few DTOs to more easily handle responses.
Related issues
closes #1343
Pull Request Checklist
mvn clean install -DskipTestslocally before committing