chore(atomix): fix flaky test #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to wait until all entries are replicated to all nodes to make the test reliable
pihme
approved these changes
May 25, 2020
|
bors r+ |
zeebe-bors bot
added a commit
that referenced
this pull request
May 25, 2020
4589: chore(atomix): fix flaky test r=pihme a=Zelldon # Description We need to wait until all entries are replicated to all nodes to make the test reliable. Tried it locally after 26 runs the test failed, after fixing it I run it 100 times without any failures. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #4588 # Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Build failed |
|
bors retry |
zeebe-bors bot
added a commit
that referenced
this pull request
May 25, 2020
4589: chore(atomix): fix flaky test r=pihme a=Zelldon # Description We need to wait until all entries are replicated to all nodes to make the test reliable. Tried it locally after 26 runs the test failed, after fixing it I run it 100 times without any failures. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #4588 # Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into develop (it was a non-fast-forward update). It will be automatically retried. |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to wait until all entries are replicated to all nodes to make the test reliable.
Tried it locally after 26 runs the test failed, after fixing it I run it 100 times without any failures.
Related issues
closes #4588
Pull Request Checklist
mvn clean install -DskipTestslocally before committing