chore(engine): migrate sub-process processor #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2020
korthout
approved these changes
May 25, 2020
| @@ -56,37 +147,4 @@ public void onChildTerminated( | |||
| eventSubscriptionBehavior.publishTriggeredEventSubProcess(flowScopeContext); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think you don't mean to forget the todo on line 129, so here's a reminder :)
There was a problem hiding this comment.
Ok, I removed the TODO and added a comment on the state issue :)
zeebe-bors bot
added a commit
that referenced
this pull request
May 26, 2020
4591: [Backport] Interrupt Sub-Process with parallel gateway r=saig0 a=saig0 ## Description * publish only deferred boundary events when the sub-process is terminated to avoid that other events are published (e.g. a taken sequence flow on a joining parallel gateway) ## Related issues Backport of #4590 # Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
zeebe-bors bot
added a commit
that referenced
this pull request
May 26, 2020
4592: [Backport] Interrupt Sub-Process with parallel gateway r=saig0 a=saig0 ## Description * publish only deferred boundary events when the sub-process is terminated to avoid that other events are published (e.g. a taken sequence flow on a joining parallel gateway) ## Related issues Backport of #4590 # Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
* fix termination of an embedded sub-process with a waiting token on a joining parallel gateway * clean up tests for embedded sub-process
saig0
force-pushed
the
4474-migrate-sub-process
branch
from
13e28de
to
7de4c75
Compare
|
bors r+ |
zeebe-bors bot
added a commit
that referenced
this pull request
May 26, 2020
4590: chore(engine): migrate sub-process processor r=saig0 a=saig0 # Description * migrate sub-process processor * fix termination of an embedded sub-process with a waiting token on a joining parallel gateway * clean up tests for embedded sub-process ## Related issues closes #4474 closes #4400 closes #4352 # Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Build failed |
|
bors retry |
zeebe-bors bot
added a commit
that referenced
this pull request
May 26, 2020
4590: chore(engine): migrate sub-process processor r=saig0 a=saig0 # Description * migrate sub-process processor * fix termination of an embedded sub-process with a waiting token on a joining parallel gateway * clean up tests for embedded sub-process ## Related issues closes #4474 closes #4400 closes #4352 # Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Build failed |
|
bors r+ |
zeebe-bors bot
added a commit
that referenced
this pull request
May 26, 2020
4590: chore(engine): migrate sub-process processor r=saig0 a=saig0 # Description * migrate sub-process processor * fix termination of an embedded sub-process with a waiting token on a joining parallel gateway * clean up tests for embedded sub-process ## Related issues closes #4474 closes #4400 closes #4352 # Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Build failed |
|
bors r+ ..please 💰 |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #4474
closes #4400
closes #4352
Pull Request Checklist
mvn clean install -DskipTestslocally before committing