Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(broker): fix environment variable #4615

Merged
merged 1 commit into from May 28, 2020
Merged

Conversation

deepthidevaki
Copy link
Contributor

Description

Fix environment variable names

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work 🙂

To be safe, can we add tests for these, as we do for the other config tests? I know this is tedious, sorry 🙈

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@deepthidevaki
Copy link
Contributor Author

bors r+

zeebe-bors bot added a commit that referenced this pull request May 28, 2020
4615: chore(broker): fix environment variable r=deepthidevaki a=deepthidevaki

## Description

Fix environment variable names

## Pull Request Checklist

- [x] All commit messages match our [commit message guidelines](https://github.com/zeebe-io/zeebe/blob/develop/CONTRIBUTING.md#commit-message-guidelines)
- [x] The submitting code follows our [code style](https://github.com/zeebe-io/zeebe/wiki/Code-Style)
- [x] If submitting code, please run `mvn clean install -DskipTests` locally before committing


Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented May 28, 2020

Build failed

@deepthidevaki
Copy link
Contributor Author

bors retry

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented May 28, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 4291f0e into stable/0.20 May 28, 2020
@zeebe-bors zeebe-bors bot deleted the fix-0.20.3-rc1-env branch May 28, 2020 13:55
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
* refactor: convert optional process filters to Carbon

* chore: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants