chore(atomix): extract flaky version updates from testSwimProtocol #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
changed the title
Zelldon
approved these changes
Jun 2, 2020
atomix/cluster/src/test/java/io/atomix/cluster/protocol/SwimProtocolTest.java
Outdated
Show resolved
Hide resolved
atomix/cluster/src/test/java/io/atomix/cluster/protocol/SwimProtocolTest.java
Outdated
Show resolved
Hide resolved
atomix/cluster/src/test/java/io/atomix/cluster/protocol/SwimProtocolTest.java
Outdated
Show resolved
Hide resolved
|
Good point, I committed the suggestions 🙂 |
- extract test functionality into separate test, which tests that members joining with a version greater than the previously known ones override older members with a lower version
npepinpe
force-pushed
the
4633-swim-version-updates
branch
from
cf04698
to
16fcd28
Compare
|
bors r+ |
zeebe-bors bot
added a commit
that referenced
this pull request
Jun 2, 2020
4647: chore(atomix): extract flaky version updates from testSwimProtocol r=npepinpe a=npepinpe ## Description This PR fixes the flakiness in the `testSwimProtocol` test at the end. It was not a false positive, but really a flake, where sometimes the member would be removed from the cluster when its new version joined, but sometimes it would be removed due to missed probes (depending on timing), and so a REACHABILITY_CHANGED event would be sent. Fix was to extract testing that newer versions evict older versions of a member into a separate test, and not stopping the older member (since it isn't really necessary afaik - correct me if I'm wrong). ## Related issues closes #4633 # Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
Build failed |
|
bors retry |
Build succeeded |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
* feat(project): use OpenSearch 2 and Elasticsearch 8 * fix(chore): remove duplicate deps * feat(backend): introduce ProcessStore for Process and ProcessInstances Related with #4617 * feat(backend): add null check for permission service Related with #4617 * feat(backend): return null instead of throw exception * feat(backend): return empty Optional in case of error * feat(backend): check for null permissions * feat(backend): use store.NotFoundException * feat(backend): use null allowed object for allAllowed * feat(backend): store.NotFoundException is a OperateRuntimeException * feat(backend): add deletion of documents in index to ProcessStore * feat(backend): factor out allowed process ids * feat(backend): remove SearchHit (ELS) from ImportBatch Related with #4644 * feat(backend): clean up Related with #4644 * feat(backend): refactor ImportPositionHolder to use ImportStore Related with #4644 * feat(backend): add missing classes to load in test Related with #4617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the flakiness in the
testSwimProtocoltest at the end. It was not a false positive, but really a flake, where sometimes the member would be removed from the cluster when its new version joined, but sometimes it would be removed due to missed probes (depending on timing), and so a REACHABILITY_CHANGED event would be sent. Fix was to extract testing that newer versions evict older versions of a member into a separate test, and not stopping the older member (since it isn't really necessary afaik - correct me if I'm wrong).Related issues
closes #4633
Pull Request Checklist
mvn clean install -DskipTestslocally before committing