Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporters/elasticsearch-exporter): custom headers #4666

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jun 4, 2020

Description

  • service tasks with custom headers that contain a dot can lead to mapping failures in ES
  • avoid mapping failures by disabling the index of custom headers for job and job batch records

Related issues

closes #4640

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

* service tasks with custom headers that contains a dot can lead to mapping failures in ES
* avoid mapping failures by disabling the index of custom headers for job and job batch records
@saig0 saig0 requested review from korthout and sdorokhova June 4, 2020 12:41
@saig0
Copy link
Member Author

saig0 commented Jun 4, 2020

@sdorokhova, this PR change the customHeaders property in ES template for job and job batch records. Please check if this change can lead to any problems in Operate. Thank you 🍪

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sdorokhova sdorokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested similar change on Operate 1.2.1. Should be fine on current version either!

@saig0
Copy link
Member Author

saig0 commented Jun 5, 2020

bors r+

@saig0
Copy link
Member Author

saig0 commented Jun 5, 2020

@korthout , @sdorokhova : thank you for the fast review 🍪

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 5, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 11a32c5 into develop Jun 5, 2020
@zeebe-bors zeebe-bors bot deleted the 4640-es-custom-headers branch June 5, 2020 11:23
zeebe-bors bot added a commit that referenced this pull request Jun 5, 2020
4669: [Backport] fix(exporters/elasticsearch-exporter): custom headers r=saig0 a=saig0

## Description

* service tasks with custom headers that contain a dot can lead to mapping failures in ES
* avoid mapping failures by disabling the index of custom headers for job and job batch records

## Related issues

backport of #4666 to `0.22`

#

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
zeebe-bors bot added a commit that referenced this pull request Jun 5, 2020
4670: [Backport] fix(exporters/elasticsearch-exporter): custom headers r=saig0 a=saig0

## Description

* service tasks with custom headers that contains a dot can lead to mapping failures in ES
* avoid mapping failures by disabling the index of custom headers for job and job batch records

## Related issues

backport of #4666 to `0.23`

#

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
zeebe-bors bot added a commit that referenced this pull request Jun 5, 2020
4669: [Backport] fix(exporters/elasticsearch-exporter): custom headers r=saig0 a=saig0

## Description

* service tasks with custom headers that contain a dot can lead to mapping failures in ES
* avoid mapping failures by disabling the index of custom headers for job and job batch records

## Related issues

backport of #4666 to `0.22`

#

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
zeebe-bors bot added a commit that referenced this pull request Jun 5, 2020
4669: [Backport] fix(exporters/elasticsearch-exporter): custom headers r=saig0 a=saig0

## Description

* service tasks with custom headers that contain a dot can lead to mapping failures in ES
* avoid mapping failures by disabling the index of custom headers for job and job batch records

## Related issues

backport of #4666 to `0.22`

#

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
zeebe-bors bot added a commit that referenced this pull request Jun 5, 2020
4669: [Backport] fix(exporters/elasticsearch-exporter): custom headers r=saig0 a=saig0

## Description

* service tasks with custom headers that contain a dot can lead to mapping failures in ES
* avoid mapping failures by disabling the index of custom headers for job and job batch records

## Related issues

backport of #4666 to `0.22`

#

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
zeebe-bors bot added a commit that referenced this pull request Jun 5, 2020
4669: [Backport] fix(exporters/elasticsearch-exporter): custom headers r=saig0 a=saig0

## Description

* service tasks with custom headers that contain a dot can lead to mapping failures in ES
* avoid mapping failures by disabling the index of custom headers for job and job batch records

## Related issues

backport of #4666 to `0.22`

#

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
* refactor: migrate process instances diagram panel to Carbon

* style: migrate statistics overlay component to Carbon

* fix: fetch process statistics on filter change

* chore: use spacing tokens for badges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticsearch mapper_parsing_exception - object mapping for [value.customHeaders.payload]
4 participants