Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] fix(exporters/elasticsearch-exporter): custom headers #4670

Merged
merged 1 commit into from
Jun 5, 2020
Merged

[Backport] fix(exporters/elasticsearch-exporter): custom headers #4670

merged 1 commit into from
Jun 5, 2020

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jun 4, 2020 •
edited

Description

  • service tasks with custom headers that contains a dot can lead to mapping failures in ES
  • avoid mapping failures by disabling the index of custom headers for job and job batch records

Related issues

backport of #4666 to 0.23

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@saig0
fix(exporters/elasticsearch-exporter): custom headers
dc17e64 
* service tasks with custom headers that contains a dot can lead to mapping failures in ES
* avoid mapping failures by disabling the index of custom headers for job and job batch records
@saig0 saig0 requested review from korthout and sdorokhova June 4, 2020 13:59
@saig0
Copy link
Member Author

saig0 commented Jun 4, 2020 •
edited

@sdorokhova, this PR change the customHeaders property in ES template for job and job batch records.

Please check if this change can lead to any problems in Operate when applying the patch to 0.23. Thank you 🍰

@saig0 saig0 changed the title fix(exporters/elasticsearch-exporter): custom headers [Backport] fix(exporters/elasticsearch-exporter): custom headers Jun 5, 2020
korthout
korthout approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdorokhova
sdorokhova approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@sdorokhova sdorokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested simialr change on 1.2.1. Looks fine!

@saig0
Copy link
Member Author

saig0 commented Jun 5, 2020

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 5, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 0bf0791 into stable/0.23 Jun 5, 2020
@zeebe-bors zeebe-bors bot deleted the 4640-backport-0.23 branch June 5, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korthout korthout korthout approved these changes

@sdorokhova sdorokhova sdorokhova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saig0 @korthout @sdorokhova @npepinpe