Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(qa/integration-tests): improve test stability #4692

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jun 10, 2020

Description

  • open the log reader first to avoid concurrent access to the log (e.g. during log compaction)

Related issues

closes #4430

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

* open the log reader first to avoid concurrent access to the log (e.g. during log compaction)
@saig0
Copy link
Member Author

saig0 commented Jun 10, 2020

I ran it multiple times in the CI and it looks good so far 🤞
However, no promise because I wasn't able to reproduce it locally.

In general, I'm not so happy about how this test is written because it has some assumptions about how Zeeebe works internally (e.g. snapshotting, log segment directories, etc.).

@saig0 saig0 requested a review from deepthidevaki June 10, 2020 12:52
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepthidevaki
Copy link
Contributor

bors r+

zeebe-bors bot added a commit that referenced this pull request Jun 11, 2020
4692: test(qa/integration-tests): improve test stability r=deepthidevaki a=saig0

## Description

* open the log reader first to avoid concurrent access to the log (e.g. during log compaction)

## Related issues

closes #4430

#

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 11, 2020

Build failed

@saig0
Copy link
Member Author

saig0 commented Jun 12, 2020

bors retry

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 12, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 9465ad3 into develop Jun 12, 2020
@zeebe-bors zeebe-bors bot deleted the 4430-flaky-deletion-test branch June 12, 2020 12:01
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
+ add test case when both INCIDENT CREATED and INCIDENT RESOLVED are processed together

closes #4692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SingleBrokerDataDeletionTest.shouldNotCompactNotExportedEvents flaky
4 participants