Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] fix(engine): check element instance before trigger timer #4727

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jun 15, 2020

Description

  • trigger timer only if the related element instance is still activated
  • remove element instance on terminated
  • replace old stream processor test with new record batch style

Related issues

Backport of #4713

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

* trigger timer only if the related element instance is still activated
* remove element instance on terminated
* replace old stream processor test with new record batch style
@saig0 saig0 requested a review from korthout June 15, 2020 09:30
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saig0
Copy link
Member Author

saig0 commented Jun 15, 2020

bors +

@saig0
Copy link
Member Author

saig0 commented Jun 16, 2020

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 16, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit dc4d495 into stable/0.23 Jun 16, 2020
@zeebe-bors zeebe-bors bot deleted the 4713-backport-0.23 branch June 16, 2020 05:16
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
* style: add operation buttons for existing variables

* refactor: remove unnecessary title

* refactor: rename prop

* refactor: remove unnecessary title and rephrase icon description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants