chore(atomix): rm partition membership service #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartitionGroupMembershipService was only used to detect new or other partition groups and to join them. This is no longer necessary since we use a static configuration.
3 tasks
deepthidevaki
requested changes
Jun 18, 2020
Zelldon
force-pushed
the
4738-rm-partition-membership
branch
from
d9b108d
to
84c9db8
Compare
|
@deepthidevaki thanks. I updated the PR and remove some more code. |
Zelldon
force-pushed
the
4738-rm-partition-membership
branch
from
84c9db8
to
660777c
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@deepthidevaki as discussed
PartitionGroupMembershipService was only used to detect new or other
partition groups and to join them. This is no longer necessary since we
use a static configuration.
Related issues
closes #4738
Pull Request Checklist
mvn clean install -DskipTestslocally before committing