Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(atomix): add receiver info to timeout exception #4756

Merged
merged 1 commit into from
Jun 22, 2020
Merged

chore(atomix): add receiver info to timeout exception #4756

merged 1 commit into from
Jun 22, 2020

Conversation

MiguelPires
Copy link
Contributor

Description

Adds information about the receiver of a message to the error message if times out.

Related issues

closes #4748

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@MiguelPires MiguelPires self-assigned this Jun 17, 2020
deepthidevaki
deepthidevaki reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have a question about an alternate way to do this.

atomix/cluster/src/main/java/io/atomix/cluster/messaging/impl/AbstractClientConnection.java Outdated
@@ -137,10 +138,12 @@ public void close() {
Callback(
final long id,
final String type,
final String receiver,

This comment was marked as resolved.

Sign in to view

@npepinpe npepinpe mentioned this pull request Jun 19, 2020
Closed
deepthidevaki
deepthidevaki approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiguelPires
Copy link
Contributor Author

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 22, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 6a1aee3 into develop Jun 22, 2020
@zeebe-bors zeebe-bors bot deleted the 4748-log-poll branch June 22, 2020 07:12
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
@huygur
style: add view full variable buttons (#4756)
1899311 
* style: add view full variable buttons

* style: truncate large variable names

* style: add right margin to icon button in icontextinput

* Revert "style: add right margin to icon button in icontextinput"

This reverts commit c535de94741c12a9213a487de94fdde129a6aa1d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthidevaki deepthidevaki deepthidevaki approved these changes

Assignees

@MiguelPires MiguelPires

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve logging of poll request failures
3 participants
@MiguelPires @deepthidevaki @npepinpe