Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(broker): use logstream name for health monitoring #4815

Merged
merged 1 commit into from
Jun 26, 2020
Merged

fix(broker): use logstream name for health monitoring #4815

merged 1 commit into from
Jun 26, 2020

Conversation

deepthidevaki
Copy link
Contributor

Description

  • Use name of logstream for consistency. Other components use actor name as the component name. But LogStream is not an actor only its implementation is an actor.

Related issues

closes #4618

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

korthout
korthout approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but does this really close #4618?

@deepthidevaki
Copy link
Contributor Author

Yes. I think so. We looked into it when the we found this issue and concluded that this is the cause.

@deepthidevaki
Copy link
Contributor Author

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jun 26, 2020

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit fb4449b into develop Jun 26, 2020
@zeebe-bors zeebe-bors bot deleted the 4618-fix-unhealthy branch June 26, 2020 07:09
@deepthidevaki deepthidevaki mentioned this pull request Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korthout korthout korthout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follower partitions are falsely marked as unhealthy
3 participants
@deepthidevaki @korthout @npepinpe