Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 0.24] Reject deployment with invalid workflows #5347

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Sep 15, 2020

Description

Backport of #5316

Related issues

closes #5253

* validate the target expressions of variable mappings
* validate static timer expressions
* ignore error events that are not referenced in the workflow on validation and transformation
* transform the workflow on validation to avoid missing validations, or unexpected failures on transforming
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏅

@korthout
Copy link
Member

No backport to 0.23?

@saig0
Copy link
Member Author

saig0 commented Sep 15, 2020

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Sep 15, 2020

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit 2374596 into stable/0.24 Sep 15, 2020
@zeebe-bors zeebe-bors bot deleted the 5253-reject-deployment-0.24 branch September 15, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants