Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 0.23] Fix flaky test: MultiInstanceActivityTest.shouldTriggerNonInterruptingBoundaryEvent #5429

Merged
merged 1 commit into from
Sep 28, 2020
Merged

[Backport 0.23] Fix flaky test: MultiInstanceActivityTest.shouldTriggerNonInterruptingBoundaryEvent #5429

merged 1 commit into from
Sep 28, 2020

Conversation

korthout
Copy link
Member

@korthout korthout commented Sep 25, 2020 •
edited

Description

Backports: #5428

Fix flaky test: MultiInstanceActivityTest.shouldTriggerNonInterruptingBoundaryEvent

Related issues

closes #5098

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@korthout korthout requested a review from saig0 September 25, 2020 14:12
@GitCop

This comment has been minimized.

Sign in to view
@korthout
test(engine): fix flake MultiInstanceActivityTest
826dcae 
Specifically: MultiInstanceActivityTest.shouldTriggerNonInterruptingBoundaryEvent
(cherry picked from commit beff49f)
@korthout
Copy link
Member Author

@saig0 please have another look

saig0
saig0 approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🍪

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Sep 28, 2020

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit 6bd1ddd into stable/0.23 Sep 28, 2020
@zeebe-bors zeebe-bors bot deleted the backport-5428-to-stable/0.23 branch September 28, 2020 12:13
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
@huygur
feat: filter grouped decisions by tenant (#5429)
ce63886 
* feat: filter grouped decisions by tenant

* chore: revert mocking multiTenancy config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@korthout @GitCop @saig0 @npepinpe