[Backport 0.24] Updates exporter position when skipping if possible #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows compaction to occur even when an exporter skips all records iff it is up to date - keeps track of last acknowledged and unacknowledged position of exporters in ExporterContainer - when skipping a record (whether for all, or a single exporter), if the exporter is up to date (meaning its last acknowledged position is greater than or equal to its last unacknowledged position), then automatically acknowledge that position
8 tasks
npepinpe
changed the title
zeebe-bors bot
added a commit
that referenced
this pull request
Sep 28, 2020
5434: [Backport 0.24] Updates exporter position when skipping if possible r=saig0 a=npepinpe ## Description Backport of #5388. A simple cherry-pick where I had to fix a merge conflict in the `ExporterDirector.ExporterContainer#updateLastExportedRecordPosition`, since 0.24 does not have a metric there (which 0.25 will have). ## Related issues closes #3166 ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [x] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [x] The behavior is tested manually * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
zeebe-bors bot
added a commit
that referenced
this pull request
Sep 28, 2020
5435: [Backport 0.23] Updates exporter position when skipping if possible r=saig0 a=npepinpe ## Description Backport of #5434. A simple cherry-pick of the 0.24 back port to avoid the merge conflict again (see the 0.24 backport issue on this). ## Related issues closes #3166 ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [x] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [x] The behavior is tested manually * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5388. A simple cherry-pick where I had to fix a merge conflict in the
ExporterDirector.ExporterContainer#updateLastExportedRecordPosition, since 0.24 does not have a metric there (which 0.25 will have).Related issues
closes #3166
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: