Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 0.24] Fix flaky CancelWorkflowInstanceConcurrentlyTest #5489

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

korthout
Copy link
Member

@korthout korthout commented Oct 6, 2020

Description

There was a timing issue in the multi-instance scenario, where the test
did not wait for both of the jobs to be created. Then when re-starting
the engine, reprocessing occurs including the verification of
reprocessing which would then fail because of this inconsistency.

By waiting for 2 jobs to be created and then taking the 1 of the correct
type, instead of just waiting for the 1 job, the test has become stable..

Related issues

closes #3606

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

There was a timing issue in the multi-instance scenario, where the test
did not wait for both of the jobs to be created. Then when re-starting
the engine, reprocessing occurs including the verification of
reprocessing which would then fail because of this inconsistency.

By waiting for 2 jobs to be created and then taking the 1 of the correct
type, instead of just waiting for the 1 job, the test has become stable..

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
(cherry picked from commit 7b63491)
@korthout korthout requested a review from Zelldon October 6, 2020 09:00
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Oct 7, 2020

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit 32a5924 into stable/0.24 Oct 7, 2020
@zeebe-bors zeebe-bors bot deleted the korthout-3606-fix-flaky-test-0.24 branch October 7, 2020 11:00
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
* fix(backend): use conditional in ElasticsearchSessionRepository

* fix(backend): use context environment for determining database

- Docker image didn't work without this.

* feat(backend): add docker-compose file for Opensearch database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants