[Backport 0.23] Fix flaky CancelWorkflowInstanceConcurrentlyTest #5491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a timing issue in the multi-instance scenario, where the test did not wait for both of the jobs to be created. Then when re-starting the engine, reprocessing occurs including the verification of reprocessing which would then fail because of this inconsistency. By waiting for 2 jobs to be created and then taking the 1 of the correct type, instead of just waiting for the 1 job, the test has become stable.. Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com> (cherry picked from commit 7b63491)
zeebe-bors bot
added a commit
that referenced
this pull request
Oct 7, 2020
5491: [Backport 0.23] Fix flaky CancelWorkflowInstanceConcurrentlyTest r=Zelldon a=korthout ## Description There was a timing issue in the multi-instance scenario, where the test did not wait for both of the jobs to be created. Then when re-starting the engine, reprocessing occurs including the verification of reprocessing which would then fail because of this inconsistency. By waiting for 2 jobs to be created and then taking the 1 of the correct type, instead of just waiting for the 1 job, the test has become stable. ## Related issues closes #3606 ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [x] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions Testing: * [ ] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [x] The behavior is tested manually * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Nico korthout <nico.korthout@camunda.com>
|
Build failed: |
|
Just a flaky test bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a timing issue in the multi-instance scenario, where the test
did not wait for both of the jobs to be created. Then when re-starting
the engine, reprocessing occurs including the verification of
reprocessing which would then fail because of this inconsistency.
By waiting for 2 jobs to be created and then taking the 1 of the correct
type, instead of just waiting for the 1 job, the test has become stable.
Related issues
closes #3606
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: