Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 0.23] Fix flaky CancelWorkflowInstanceConcurrentlyTest again #5554

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

korthout
Copy link
Member

@korthout korthout commented Oct 9, 2020

Description

The test has multiple scenarios, and the sequential scenario actually
only expects 1 job to become activatable.

In addition, in the scenarios where we expect 2 jobs to become
activatable, it was not enough to just limit the stream to 2 when only
grabbing one specific one. This because it might not be clear which job
is created first. Therefore, the tests should always first assert that
all expected jobs have been created and then continue.

Related issues

backports #5550
closes #3606

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

The test has multiple scenarios, and the sequential scenario actually
only expects 1 job to become activatable.

In addition, in the scenarios where we expect 2 jobs to become
activatable, it was not enough to just limit the stream to 2 when only
grabbing one specific one. This because it might not be clear which job
is created first. Therefore, the tests should always first assert that
all expected jobs have been created and then continue.

(cherry picked from commit 29c8c38)
@korthout korthout requested a review from saig0 October 9, 2020 09:35
@korthout korthout changed the title [Backport 0.24] Fix flaky CancelWorkflowInstanceConcurrentlyTest again [Backport 0.23] Fix flaky CancelWorkflowInstanceConcurrentlyTest again Oct 9, 2020
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🍪

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Oct 9, 2020

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit 561d4a1 into stable/0.23 Oct 9, 2020
@zeebe-bors zeebe-bors bot deleted the korthout-3606-fix-flaky-test-again-0.23 branch October 9, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants