Show container logs on update test failure #5872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't backport to 0.24 because I already fixed it on that branch. |
zeebe-bors bot
added a commit
that referenced
this pull request
Nov 18, 2020
5872: Show container logs on update test failure r=MiguelPires a=npepinpe ## Description In the refactoring, it seems I broke showing the container logs when the test fails. This was because the `TestWatcher` extension is called after the resources have been closed, as a `TestWatcher` is supposed to only report on outcomes. I've moved the `onFailure` of the `ContainerState` now to the after test callback, and we can see if it failed by checking if an exception was thrown and not caught during the test. ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [x] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [x] New tests are written to ensure backwards compatibility with further versions * [x] The behavior is tested manually * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
bors retry weird because only the bors check is red, its merge build passed |
zeebe-bors bot
added a commit
that referenced
this pull request
Nov 18, 2020
5872: Show container logs on update test failure r=MiguelPires a=npepinpe ## Description In the refactoring, it seems I broke showing the container logs when the test fails. This was because the `TestWatcher` extension is called after the resources have been closed, as a `TestWatcher` is supposed to only report on outcomes. I've moved the `onFailure` of the `ContainerState` now to the after test callback, and we can see if it failed by checking if an exception was thrown and not caught during the test. ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [x] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [x] New tests are written to ensure backwards compatibility with further versions * [x] The behavior is tested manually * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
bors retry |
zeebe-bors bot
added a commit
that referenced
this pull request
Nov 19, 2020
5872: Show container logs on update test failure r=MiguelPires a=npepinpe ## Description In the refactoring, it seems I broke showing the container logs when the test fails. This was because the `TestWatcher` extension is called after the resources have been closed, as a `TestWatcher` is supposed to only report on outcomes. I've moved the `onFailure` of the `ContainerState` now to the after test callback, and we can see if it failed by checking if an exception was thrown and not caught during the test. ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [x] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [x] New tests are written to ensure backwards compatibility with further versions * [x] The behavior is tested manually * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
The build hasn't finished yet and bors already failed it 🤔 |
|
bors retry |
zeebe-bors bot
added a commit
that referenced
this pull request
Nov 19, 2020
5872: Show container logs on update test failure r=MiguelPires a=npepinpe ## Description In the refactoring, it seems I broke showing the container logs when the test fails. This was because the `TestWatcher` extension is called after the resources have been closed, as a `TestWatcher` is supposed to only report on outcomes. I've moved the `onFailure` of the `ContainerState` now to the after test callback, and we can see if it failed by checking if an exception was thrown and not caught during the test. ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [x] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [x] New tests are written to ensure backwards compatibility with further versions * [x] The behavior is tested manually * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
|
Successfully created backport PR #5895 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the refactoring, it seems I broke showing the container logs when the test fails. This was because the
TestWatcherextension is called after the resources have been closed, as aTestWatcheris supposed to only report on outcomes. I've moved theonFailureof theContainerStatenow to the after test callback, and we can see if it failed by checking if an exception was thrown and not caught during the test.Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: