Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time instead of authors? #326

Open
mircealungu opened this issue Mar 19, 2024 · 4 comments
Open

time instead of authors? #326

mircealungu opened this issue Mar 19, 2024 · 4 comments

Comments

@mircealungu
Copy link
Member

we are not extracting the authors correctly from some articles. happens at least in Politiken (e..g https://www.zeeguu.org/read/article?id=2455030) and DR (e.g. https://www.zeeguu.org/read/article?id=2445554).

as a result, the reader can be confusing at times:

image

Also, we're not showing the article date in the reader.

I propose the following solution:

replace the authors list in the reader with the date

what do you think @igawaclawska and @tfnribeiro ?

@tfnribeiro
Copy link
Contributor

tfnribeiro commented Mar 19, 2024

I agree, maybe it would be good to include the source icon as well:

image

I think it's more likely that people associate the articles with sources than specific authors.

@igawaclawska
Copy link
Contributor

I propose the following solution:

replace the authors list in the reader with the date

@mircealungu, I like the idea! Also, I have observed that (so far) it only happens in the reader from the app, the reader in the extension can extract the authors. I will check more articles to confirm if though. If so, maybe comparing parsing solutions in both cases could help fix it 🤔

@tfnribeiro
Copy link
Contributor

That's a good point Iga, we parse the documents slightly differently from the Extension VS the Browser, so maybe this would be a problem that would fix itself once we unify the two readers.

@igawaclawska
Copy link
Contributor

igawaclawska commented Mar 19, 2024

I think it's very likely. But I also like the solution of showing the source logo and a date (before we figure out why the author is not extracted correctly). If unifying two readers fixes the parsing issue, I would still leave the source logo present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants