Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draw=TRUE parameter to condformat2grob function #31

Merged
merged 1 commit into from Nov 26, 2022

Conversation

interzoneboy
Copy link

No description provided.

@zeehio zeehio merged commit fd4009e into zeehio:master Nov 26, 2022
@zeehio
Copy link
Owner

zeehio commented Nov 26, 2022

Thank you for the pull request

Before your pull request, the condformat2grob() tests in conformat were always creating some annoying plot windows. Now I've changed them to use draw=FALSE, to avoid the window being created. This is very convenient for all condformat contributors (myself included). Besides, the test output is now checked automatically using vdiffr, so if something breaks or changes we will notice.

Thank you very much for this.

@interzoneboy
Copy link
Author

This makes me very happy. This is a very useful package, and honestly when is anything in life this easy to fix? =)
Also this was my first "real" experience opening an issue, submitting a pull request, and corresponding on here. I had to figure out how to do all that (obviously it wasn't difficult), and I'm very glad that I know all the steps now. Thanks for nudging me to do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants