Update CAF submodule #275
Merged
Update CAF submodule #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwoj
approved these changes
Sep 6, 2022
15 tasks
timwoj
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 5ad9e8e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CAF to fix an issue in Broker where the pipeline could stall, completely blocking communication eventually. Relates zeek/zeek#2389. Also includes a patch that backports the
process_open_fdsPrometheus metric (very useful to double-check whether the peerings recorded by Broker are actually accurate).Unfortunately, this isn't the end of the story. In my test setup, I sometimes get Broker into a state where peers would constantly disconnect and then reconnect. This would match the "flurry of activity in cluster.log" that Christian's reported. That bug is most likely on the Broker side and I'm already looking into it.