Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Zeek scripts to install explicitly. #77

Closed
rsmmr opened this issue Jul 15, 2021 · 0 comments · Fixed by #83
Closed

Specify Zeek scripts to install explicitly. #77

rsmmr opened this issue Jul 15, 2021 · 0 comments · Fixed by #83
Assignees
@bbannier

Comments

@rsmmr
Copy link
Member

rsmmr commented Jul 15, 2021

Right now we do a blanket install of all *.{zeek,sig}. From analyzer/CMakeLists.txt:

# TODO: Should probably switch to listing the scripts to be installed.
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/
            DESTINATION "${SPICY_SCRIPTS_OUTPUT_DIR_INSTALL}/spicy-analyzers"
            FILES_MATCHING PATTERN "*.zeek" PATTERN "*.sig"
        )
bbannier added a commit that referenced this issue Sep 9, 2021
@bbannier
Explicitly list scripts to install.
b7ae503 
This patch adds a new CMake function `spicy_analyzer` takes similar
arguments as `spicy_add_analyzer`, but which can additionally accept a
list of scripts to install via a `SCRIPTS` parameter. In order to
support different directories for file and protocol analyzer scripts
this function also requires explicitly passing in an analyzer `KIND`
(for our current use cases: either `file` or `protocol`).

Closes #77.
@bbannier bbannier mentioned this issue Sep 9, 2021
Merged
@bbannier bbannier self-assigned this Sep 9, 2021
bbannier added a commit that referenced this issue Sep 9, 2021
@bbannier
Explicitly list scripts to install.
6935370 
This patch adds a new CMake function `spicy_analyzer` takes similar
arguments as `spicy_add_analyzer`, but which can additionally accept a
list of scripts to install via a `SCRIPTS` parameter. In order to
support different directories for file and protocol analyzer scripts
this function also requires explicitly passing in an analyzer `KIND`
(for our current use cases: either `file` or `protocol`).

Closes #77.
@bbannier bbannier mentioned this issue Sep 10, 2021
Closed
bbannier added a commit that referenced this issue Sep 10, 2021
@bbannier
Explicitly list scripts to install.
272658b 
With this patch we now use named arguments to `spicy_add_plugin` which
allows us to pass additional Zeek scripts to install.

Closes #77.

Don't install.

This reverts commit 59a65a185b81e2ece29aeb62462201a42fdf0c55.
bbannier added a commit that referenced this issue Sep 10, 2021
@bbannier
Explicitly list scripts to install.
79bb7c7 
With this patch we now use named arguments to `spicy_add_plugin` which
allows us to pass additional Zeek scripts to install.

Closes #77.

Don't install.

This reverts commit 59a65a185b81e2ece29aeb62462201a42fdf0c55.
bbannier added a commit that referenced this issue Sep 13, 2021
@bbannier
Explicitly list scripts to install.
6aa3ad8 
With this patch we now use named arguments to `spicy_add_plugin` which
allows us to pass additional Zeek scripts to install.

Closes #77.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbannier bbannier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly list scripts to install. zeek/spicy-analyzers
2 participants
@bbannier @rsmmr