Make sure container sizes are runtime integers. #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the HILTI runtime containers we previously directly forwarded the `size` functions of the underlying stdlib containers. This could have lead to them returning a type not expected by our runtime, e.g., on macos these might return `unsigned long` values which our runtime e.g., doesn't know how to print. This patch changes these functions so that now they return types which we expect our runtimes to be able to work with.
rsmmr
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the HILTI runtime containers we previously directly forwarded the
sizefunctions of the underlying stdlib containers. This could havelead to them returning a type not expected by our runtime, e.g., on
macos these might return
unsigned longvalues which our runtime e.g.,doesn't know how to print.
This patch changes these functions so that now they return types which
we expect our runtimes to be able to work with.