Merge remote-tracking branch 'origin/topic/jsiwek/fix-ConnectionEvent…

…-leak' * origin/topic/jsiwek/fix-ConnectionEvent-leak: Fix memory leak in deprecated Analyzer::ConnectionEvent()
zeek · Nov 17, 2020 · 995d889 · 995d889
2 parents e1c07ff + 6503068
commit 995d889
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGES b/CHANGES
@@ -1,4 +1,8 @@
 
+3.3.0-dev.546 | 2020-11-17 11:50:47 +0000
+
+  * Fix memory leak in deprecated Analyzer::ConnectionEvent() (Jon Siwek, Corelight)
+
 3.3.0-dev.543 | 2020-11-16 11:50:49 -0800
 
   * GH-352: Improve HTTP::match_sql_injection_uri regex (Jon Siwek, Corelight)

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-3.3.0-dev.543
+3.3.0-dev.546
diff --git a/src/analyzer/Analyzer.cc b/src/analyzer/Analyzer.cc
@@ -811,6 +811,7 @@ void Analyzer::Event(EventHandlerPtr f, Val* v1, Val* v2)
 void Analyzer::ConnectionEvent(EventHandlerPtr f, ValPList* vl)
 	{
 	auto args = val_list_to_args(*vl);
+	delete vl;
 
 	if ( f )
 		conn->EnqueueEvent(f, this, std::move(args));