Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEEK SMTP Header Parsing Issue #1352

Closed
sumit240690 opened this issue Jan 8, 2021 · 4 comments · Fixed by #1365
Closed

ZEEK SMTP Header Parsing Issue #1352

sumit240690 opened this issue Jan 8, 2021 · 4 comments · Fixed by #1365
Assignees
Milestone

Comments

@sumit240690
Copy link

There is an issue with SMTP parsing where header extraction continues parsing into the body and attachments of emails. A common case which leads this issue to surface appears when emails are sent as attachments. If you have an attachment that itself is an email, the headers from the attached email will override headers parsed from the actual email.

This incidentally might be the cause of previously seen issues such as #254.

@timwoj
Copy link
Contributor

timwoj commented Jan 8, 2021

Do you by chance have a pcap that illustrates it? That would help in tracking down the issue.

@sumit240690
Copy link
Author

Hi,

We have proposed the following changes as explained in the below PR:

#1357

Please let us know if you still need pcap ?

Thanks.

@0xxon
Copy link
Member

0xxon commented Jan 11, 2021

Hi,

thanks for the PR. A pcap actually still would be helpful for reproduction - and for inclusion in the testsuite. Alternatively - it would be great if you could add a testcase to the PR :).

Thank you very much,
Johanna

@theavgjojo
Copy link

@0xxon, check out #1365 -- PCAP and test case added.

@jsiwek jsiwek self-assigned this Jan 19, 2021
@jsiwek jsiwek added this to Unassigned / Todo in Release 4.0.0 via automation Jan 19, 2021
@jsiwek jsiwek added this to the 4.0.0 milestone Jan 19, 2021
theavgjojo pushed a commit to theavgjojo/zeek that referenced this issue Jan 21, 2021
oakljon added a commit to theavgjojo/zeek that referenced this issue Jan 21, 2021
jsiwek added a commit that referenced this issue Jan 22, 2021
…ithub.com/theavgjojo/zeek

* 'topic/oakljon/gh-1352-smtp-header-parsing' of https://github.com/theavgjojo/zeek:
  GH-1352: Added flag to stop processing SMTP headers in attached messages
Release 4.0.0 automation moved this from Unassigned / Todo to Done Jan 22, 2021
jsiwek pushed a commit that referenced this issue Jan 22, 2021
jsiwek pushed a commit that referenced this issue Feb 16, 2021
jsiwek pushed a commit that referenced this issue Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 4.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants